forked from AdaGold/react-chatlog
-
Couldn't load subscription status.
- Fork 17
Ocelots - Soumya #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smysh
wants to merge
11
commits into
ada-ac2:main
Choose a base branch
from
smysh:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
af28e8e
Wave 01 - added ChatEntry proptypes and used them in JSX.used TimeSta…
smysh 716a8eb
Wave 01 - Rendered one ChatEntry component in App.js. Passing all wav…
smysh ef3445f
Wave 02- added ChatLog.js to map all chats to individual ChatEntries.
smysh a5bef1d
Wave 02- changes to App.js to use ChatLog instead of ChatEntries.
smysh 040197b
Wave02- renamed chats as entries as the tests reference that. All wav…
smysh f3b8616
Wave 03 - passing down updateLikes callback function as a prop to Cha…
smysh 3a4d90b
Wave03 - added functionality to click on heart to change color.
smysh 91fd0b5
Wave03 - implemented totalLikes function to display number of hearts …
smysh b8e646e
Optional enhancements - seperating local and remote messages on left …
smysh 4e10dc1
Wave03 - made some changes to make the tests pass.
smysh bef2562
remove isRequired from props that are not required by tests.
smysh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import React from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
| import ChatEntry from './ChatEntry'; | ||
| import './ChatLog.css'; | ||
|
|
||
| const ChatLog = ({ chats }) => { | ||
| const getChatLogJSX = (chats) => { | ||
| return chats.map((chat) => { | ||
| return ( | ||
| <ChatEntry | ||
| key={chat.id} | ||
| id={chat.id} | ||
| sender={chat.sender} | ||
| body={chat.body} | ||
| timeStamp={chat.timeStamp} | ||
| liked={chat.liked} | ||
| /> | ||
| ); | ||
| }); | ||
| }; | ||
| return <ul className="chat-log">{getChatLogJSX(chats)}</ul>; | ||
| }; | ||
|
|
||
| ChatLog.propTypes = { | ||
| chats: PropTypes.arrayOf( | ||
| PropTypes.shape({ | ||
| id: PropTypes.number.isRequired, | ||
| sender: PropTypes.string.isRequired, | ||
| body: PropTypes.string.isRequired, | ||
| timeStamp: PropTypes.string.isRequired, | ||
| liked: PropTypes.bool.isRequired, | ||
| }) | ||
| ).isRequired, | ||
| }; | ||
|
|
||
| export default ChatLog; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice use of PropTypes to enforce data requirements