Ocelots - McKay Warren #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re present on Adagrams prototype
ilana-adadev
reviewed
Feb 1, 2023
| export const scoreWord = (word) => { | ||
| // Implement this method for wave 3 | ||
| }; | ||
| while (i < 10) { |
There was a problem hiding this comment.
This loops makes sense, and I don't think you really have to worry about it here, but when I see while loops like this, I think about adding some other kind of guard condition- like limiting the number of attempts, for example-- to catch a possible infinite loop if there weren't enough letters to be picked.
ilana-adadev
reviewed
Feb 1, 2023
| let usesOnlyAvailableLetters = true; | ||
| [...input].forEach((letter) => { | ||
| const index = lettersInHand.indexOf(letter); | ||
| // indexOf method return -1 if letter not found |
ilana-adadev
reviewed
Feb 1, 2023
| // indexOf method return -1 if letter not found | ||
| if (index != -1) { | ||
| // for splice, need to specify only 1 letter should be removed | ||
| lettersInHand.splice(index, 1); |
ilana-adadev
reviewed
Feb 1, 2023
| }; | ||
| let score = 0; | ||
|
|
||
| [...word].forEach((letter) => { |
ilana-adadev
reviewed
Feb 1, 2023
| const bestPlays = this.config.players | ||
| .map((player) => ({ player, ...this._bestPlay(round, player) })) | ||
| .filter(({ player, word, score }) => word !== undefined); | ||
| .map((player) => ({ player, ...this._bestPlay(round, player) })) |
There was a problem hiding this comment.
Ooh, nice use of map for looping through the players
ilana-adadev
reviewed
Feb 1, 2023
| export const drawLetters = () => { | ||
| // Implement this method for wave 1 | ||
| }; | ||
| export default class Adagrams { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.