Direct subcompose #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning Oh wait this might not work as intended, because I skip the composing in Map... It did work when I ran it though... unsure what I skip here |
|
I’m not sure if this is safe 🤔 currently the So if a parent is re-composed, but its child isn’t, the child will remain under the same ptr. Honestly I’m not 100% sure though, I’d love to start adding more advanced tests so we can start chipping away at these un-ergonomic parts (because this PR would be a huge improvement) |
matthunz
force-pushed
the
main
branch
2 times, most recently
from
10b82d8 to
326e62c
Compare
matthunz
force-pushed
the
main
branch
3 times, most recently
from
72f2ae5 to
5ae0a51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes replacing
Ref::map(cx.me(), |me| &me.content)with just&cx.me().contentpossible.