ref: Move the full jacobian and bound track parameters to the parameter_transporter and merge it with the parameter_resetter#880
Open
niermann999 wants to merge 2 commits intoacts-project:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
niermann999
force-pushed
the
ref-move-cov-transp-data
branch
from
c1e16f3 to
aa850d6
Compare
niermann999
added
refactor
niermann999
force-pushed
the
ref-move-cov-transp-data
branch
from
aa850d6 to
98994d4
Compare
niermann999
force-pushed
the
ref-move-cov-transp-data
branch
3 times, most recently
from
bb3139f to
c044806
Compare
niermann999
force-pushed
the
ref-move-cov-transp-data
branch
from
c044806 to
25e7108
Compare
|
beomki-yeo
reviewed
Nov 25, 2024
|
|
||
| /// Full jacobian | ||
| bound_matrix_type m_full_jacobian = | ||
| matrix_operator().template identity<e_bound_size, e_bound_size>(); |
Collaborator
There was a problem hiding this comment.
I think we don't have to initialize this as the identity matrix if the compiler says OK
Collaborator
Author
There was a problem hiding this comment.
I just moved this line over from the stepper, will update
niermann999
force-pushed
the
ref-move-cov-transp-data
branch
5 times, most recently
from
0ace030 to
d9f2e0c
Compare
niermann999
force-pushed
the
ref-move-cov-transp-data
branch
from
d9f2e0c to
5702171
Compare
…orter and merge the actors that modify the bound track parameters
niermann999
force-pushed
the
ref-move-cov-transp-data
branch
from
5702171 to
2988413
Compare
|
Collaborator
|
Please make sure that it runs OK in traccc before you merge the PR into the repository |
beomki-yeo
requested changes
Mar 3, 2025
Collaborator
beomki-yeo
left a comment
beomki-yeo
left a comment
There was a problem hiding this comment.
Until then, this should be held a while..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the data to the actor that updates them, to pool the update functionality with the corresponding data in a single place.
It is currently possible to call an actor like the
pointwise_material_interactorin the actor chain while forgetting to register theparameter_transporterin the same actor chain, even though the material interactor depends on the correct update of the bound track parameters. This PR makes sure, that dependent actors like the material interactor will no longer compile without the parameter_transporter by making their call operator take the parameter transporter state as an argument, which now contains the bound track parameters. Furthermore, this is abstracted in a new type, theparamerter_updater, that additionally makes sure that theparameter_resetteris called correctly, as well. Any actors that depend on the updated bound parameters and covariance can be given to this new type as template parameter list and will automatically be inserted correctly in the actor chain.In the future, it should be possible to add a second state to the parameter transporter, which does not own the bound track parameters but takes a pointer from the CKF to the current bound track parameters. This should avoid copying the bound track parameters between the CKF and the propagation. At the same time, the stepper becomes easier to reuse in a simulation context with this PR, since it is not mandatory anymore to hold the bound track parameters and full jacobian in memory.