Skip to content

Commit

Permalink
Update docs for remote e2e testing and enable i18n pre-commit
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewtavis committed Jan 21, 2025
1 parent b9bcb19 commit 767d337
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 9 deletions.
14 changes: 7 additions & 7 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ repos:
args: [--fix, --exit-non-zero-on-fix]
- id: ruff-format

# - repo: local
# hooks:
# - id: run-i18n-checks
# name: Run i18n Checks
# entry: python frontend/i18n/check/run_i18n_checks.py
# language: python
# stages: [pre-commit]
- repo: local
hooks:
- id: run-i18n-checks
name: Run i18n Checks
entry: python frontend/i18n/check/run_i18n_checks.py
language: python
stages: [pre-commit]

# - repo: https://github.com/tcort/markdown-link-check
# rev: v3.13.6
Expand Down
14 changes: 12 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -454,13 +454,23 @@ Thank you for testing locally! ✨

#### Remote E2E

To run the tests on the repository, first create a branch from the remote branch that you want to test against. This can be done with the following command:
For testing on your remote forked repository, first create a branch from the remote branch that you want to test against. This can be done with the following command:

```bash
git push upstream <local-branch-name>:<remote-branch-name-of-your-choice>
```

You can then navigate to the [actions of the repository](https://github.com/activist-org/activist/actions) and trigger [pr_ci_playwright_e2e](https://github.com/activist-org/activist/actions/workflows/pr_ci_playwright_e2e.yaml) for the remote branch that you just created.
You can then navigate to the remote versions of the [actions of the repository](https://github.com/activist-org/activist/actions) in your fork and trigger [pr_ci_playwright_e2e](https://github.com/activist-org/activist/actions/workflows/pr_ci_playwright_e2e.yaml).

For maintainers of the activist main repo, testing PRs is done via the following to make sure that origin has a copy of the branch that can be tested against:

```bash
# On the branch in question:
git branch # to find the name of the branch
git push -u origin LOCAL_NAME_OF_BRANCH
```

You can then visit the [actions of the repository](https://github.com/activist-org/activist/actions) to run the the [pr_ci_playwright_e2e](https://github.com/activist-org/activist/actions/workflows/pr_ci_playwright_e2e.yaml) test against the new branch on origin.

Thank you for testing your PRs! 🎉

Expand Down
1 change: 1 addition & 0 deletions frontend/i18n/check/i18n_check_key_identifiers.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
directories_to_skip = [
i18n_check_dir,
str((frontend_directory / ".nuxt").resolve()),
str((frontend_directory / ".output").resolve()),
str((frontend_directory / "node_modules").resolve()),
]
files_to_skip = ["i18n-map.ts"]
Expand Down

0 comments on commit 767d337

Please sign in to comment.