Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amending Italian Translations #208

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Amending Italian Translations #208

merged 2 commits into from
Dec 11, 2024

Conversation

mega5800
Copy link
Contributor

@mega5800 mega5800 commented Oct 15, 2024

👍🎉 First off, thanks for taking the time to contribute! 🎉👍

Please fill out the following checklist:

If you need any help at all, feel free to submit the PR and @-mention activescott and I'll be happy to assist!

Hello @activescott.

I took care of this ticket.

Here is the amended file filter translation:
image

@bovirus, I took the liberty and amended the Italian translations where upper case words should be lowercase.
For example:
image

I also amended the tests to use the new and correct translations

Thank you.

@mega5800
Copy link
Contributor Author

mega5800 commented Nov 6, 2024

Hello @activescott.

Can you please check this pull request and let me know if something else is required.
I'd like to start working on other tickets as well.

Thank you.

@mega5800
Copy link
Contributor Author

mega5800 commented Dec 5, 2024

Hello @activescott.

Are there any updates regarding this pull request?
In the meantime, new tickets were opened, and I'd like to start working on them please.

Thank you.

@activescott
Copy link
Owner

Thanks @mega5800. Sorry, I just missed this one in my list of GitHub notifications. Thanks for your work. It will be best for you to tag me on an issue you plan to work on before you start working to confirm that we're aligned. I want to make sure that you get the most impact for the work you're do!

@activescott activescott merged commit af0c172 into activescott:master Dec 11, 2024
2 checks passed
@activescott
Copy link
Owner

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mega5800
Copy link
Contributor Author

Hello @activescott.

Thank you for approving this pull request.
I think I will continue working on this ticket.
I already have an existing code for supporting this feature and now I'd like to add the required tests.

Hopefully, I will send a new pull request during this weekend.

Thank you.

@activescott
Copy link
Owner

@mega5800 sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants