-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add payment method icons for Scream Truck and Ansa #1288
Add payment method icons for Scream Truck and Ansa #1288
Conversation
@carolkng are you able to check the following issue with your SVG? Failure: |
@dannye0231 I've updated the icon mask id's -- would you be able to run the workflows again? Thanks! |
@carolkng one more SVG issue: Failure: rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:61 .... |
@dannye0231 updated to fix that issue (and would appreciate another workflow run)! Is there a local command off the top of your head that one could use to install test dependencies and run the test suite? |
Thanks @carolkng , looks good now. As for testing, the easiest thing would be to just let our testing workflows run once the changes have been submitted. I'll try to get this PR reviewed now in preparation for next weeks merge. |
Why are you adding this icons?
Ansa is a service that provides branded wallets for merchants on Shopify, and Scream Truck is a company that offers customer the option to pay with their own branded stored value balance. We're adding these merchant-specific icons to signal to a customer that they can pay with their Ansa balance or Scream Truck balance.
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name) Lacy (payment platform partner)
What's the expected date of this change to deploy on Shopify?
ASAP