-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Centrapay logos #1285
base: master
Are you sure you want to change the base?
Conversation
Hi @pupato13 , are you able to address the following issues found within your SVG files? Also, can you please re-base your PR? Failure: bin/rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:61 F Failure: bin/rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:53 ...F Failure: bin/rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:107 |
Hey @dannye0231, thanks for letting me know. I fixed it and pushed the changes again. It happened after running the SVGO to optimise the images. Somehow, it removes |
@pupato13 looks like it is still having issues: Failure: rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:61 Can you also re-base this PR once you have made the corrections to the SVG file? |
@dannye0231, thanks again. All missing attributes are there now. |
@pupato13 are you able to check the follow issue related to your SVG? PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:89]: rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:61 .... |
@dannye0231 fixed. Are the |
@pupato13 I think it was just caused by the missing pi- prefix |
@pupato13 are you able to remove the dash from Gift-Station from both the SVG and the YML config file?? This can potentially cause an issue after merging. Once completed, can you please re-base? |
Why are you adding this icons?
I'm adding these icons because Centrapay is a Shopify Partner and needs to show payments configured for each merchant
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?
As soon as possible