Add icons for goSettle, Carte Bleue, PostePay, Nexi #1284
Conversation
|
Hi @DjellzeBllaca, can you please re-base this PR? |
Done |
|
@DjellzeBllaca are you able to check the following error related to your SVG? Failure: bin/rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:61 |
@dannye0231 Updated the ids where the tests were failing |
|
@DjellzeBllaca can you please check your SVG? I see the following error: Failure: rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:61 ... |
Fixed |
Why are you adding this icons?
We at Buckaroo, a payment service provider, have a "Cards" app that includes all credit and debit card brands as payment methods. However, Shopify is missing icons for certain card brands, such as Carte Bleue, PostePay, and Nexi, which need to be added. Additionally, we previously submitted "Knaken Settle" a few months ago, but since Knaken has rebranded, we have updated it to "goSettle."
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.ymlIf this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
I am Djellze Bllaca and I work with Buckaroo, a payment service provider, offering a variety of payment solutions for online merchants.
What's the expected date of this change to deploy on Shopify?
As soon as possible