-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new icon for zaver #1272
base: master
Are you sure you want to change the base?
Add a new icon for zaver #1272
Conversation
Hello @Lydia-shan-git |
Hi @dannye0231 |
Hi @divyach0209 , we are aiming for Feb 5th to get these PRs merged. Can you please re-base as well? |
sure thanks for the update @dannye0231 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure your border is 1 px thick and follows the radius of 2 px as shown in the guidelines (https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md#appearance)
Removed white spaces after dash
a78fc17
to
98407aa
Compare
Hi @Lydia-shan-git So could you please help to re-review the same ? and please let me know if anything required from my side. |
Why are you adding this icons?
I'm adding/updating this icon(s) because our payment gateway offer a new payment method called Zaver.
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?