Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sistecredito Icon #1187

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Sistecredito Icon #1187

wants to merge 4 commits into from

Conversation

gomonke
Copy link
Contributor

@gomonke gomonke commented May 28, 2024 •
edited
Loading

Why are you adding this icons?

I'm adding/updating this icon(s) because we have the application approved and listed at https://apps.shopify.com/sistecredito-app. We need to update the payment method icon

Help us identify yourself

  • I'm working/collaborating with the brand directly and they have provided the icons.
  • I'm associated with the brand and I've read all the brand icon’s guidelines.
  • I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines:

Checklist to add new icons

  • All icons have a corresponding entry in db/payment_icons.yml
  • I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • I have optimized the icon with SVGO
  • I am confident that all icons are clear and easy to read/understand
  • I have provided a link to the brand icon’s brand guidelines whenever possible.
  • I have attached a screenshot comparison with the example icon provided in guidelines
  • I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

compare

Tips how to create a screenshot

We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

<!-- Change background color if needed to showcase your icon better -->
<style> body { background: black; } </style>

<!-- DO NOT DELETE EXAMPLE -->
<svg viewBox="0 0 38 24" xmlns="http://www.w3.org/2000/svg" role="img" width="38" height="24" aria-labelledby="pi-visa"><title id="pi-visa">Visa</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/></svg>

<!-- TODO: insert your icon here -->
<svg xmlns="http://www.w3.org/2000/svg" width="38" height="24" viewBox="0 0 38 24" role="img" aria-labelledby="pi-sistecredito"><title id="pi-sistecredito">sistecredito</title><g><path d="M35,0H3C1.3,0,0,1.3,0,3v18c0,1.7,1.4,3,3,3h32c1.7,0,3-1.3,3-3V3c0-1.7-1.4-3-3-3Z" style="fill:#000; isolation:isolate; opacity:.07; stroke-width:0px;"/><path d="M35,1c1.1,0,2,.9,2,2v18c0,1.1-.9,2-2,2H3c-1.1,0-2-.9-2-2V3c0-1.1.9-2,2-2h32Z" style="fill:#fff; stroke-width:0px;"/><path d="M11.78,11.6v-.84h-.92v-.87l-.66.14c-.02.12-.07.24-.14.35-.13.22-.35.37-.6.42-.01,0-.03,0-.04,0v.8h.43v1.44c-.02.29.09.58.3.78.2.18.5.26.89.26.12,0,.24-.01.35-.03.12-.01.23-.04.35-.07v-.81c-.07.02-.15.04-.23.05-.07.01-.15.02-.22.02-.12.01-.24-.02-.34-.09-.07-.08-.11-.2-.1-.31v-1.25h.92Z" style="fill:#00369c; stroke-width:0px;"/><path d="M1.5,13.68l.48-.68c.18.11.37.2.56.27.16.05.33.08.5.08.13,0,.27-.02.39-.07.08-.03.14-.1.15-.19,0-.06-.03-.12-.08-.15-.08-.05-.16-.08-.25-.08l-.65-.1c-.28-.03-.54-.14-.74-.33-.18-.17-.27-.41-.26-.65-.01-.31.13-.6.38-.78.3-.21.67-.31,1.03-.28.24,0,.48.04.71.1.23.07.45.17.66.29l-.48.64c-.16-.1-.33-.17-.51-.23-.16-.05-.32-.07-.48-.07-.11,0-.21.02-.31.06-.07.03-.11.1-.12.17,0,.06.03.12.09.16.09.05.19.08.3.09l.65.1c.28.03.54.14.75.32.17.16.27.4.26.63,0,.15-.04.31-.11.44-.08.14-.18.26-.31.35-.14.1-.3.18-.47.23-.19.06-.39.09-.59.08-.29,0-.58-.03-.86-.11-.25-.06-.48-.17-.68-.32Z" style="fill:#00369c; stroke-width:0px;"/><path d="M6.15,13.68l.48-.68c.18.11.37.2.56.27.16.05.33.08.5.08.13,0,.27-.02.39-.07.08-.03.14-.1.15-.19,0-.06-.03-.12-.08-.15-.08-.05-.16-.08-.25-.08l-.65-.1c-.28-.03-.54-.14-.74-.33-.18-.17-.27-.41-.26-.65-.01-.31.13-.6.38-.78.3-.21.67-.31,1.03-.28.24,0,.48.04.71.1.23.07.45.17.66.29l-.48.64c-.16-.1-.33-.17-.51-.23-.16-.05-.32-.07-.48-.07-.11,0-.21.02-.31.06-.07.03-.11.1-.12.17,0,.06.03.12.09.16.09.05.19.08.3.09l.65.1c.28.03.54.14.75.32.17.16.27.4.26.63,0,.15-.04.31-.11.44-.08.14-.18.26-.31.35-.14.1-.3.18-.47.23-.19.06-.39.09-.59.08-.29,0-.58-.03-.86-.11-.25-.06-.48-.17-.68-.32h0Z" style="fill:#00369c; stroke-width:0px;"/><path d="M15.19,13.61c-.19.16-.4.29-.63.38-.24.08-.48.12-.73.12-.24,0-.48-.04-.7-.13-.21-.08-.4-.2-.57-.36-.16-.15-.29-.34-.38-.54-.09-.21-.14-.44-.14-.67,0-.23.04-.46.13-.67.08-.2.21-.39.36-.54.16-.15.34-.28.54-.36.21-.09.44-.13.67-.13.45,0,.88.18,1.19.51.15.16.27.36.34.57.08.23.13.47.12.72v.25h-2.34c.07.15.17.28.31.37.15.1.32.15.5.15.13,0,.25-.02.37-.07.11-.04.2-.1.28-.18l.66.59ZM13.73,11.53c-.15,0-.3.04-.43.14-.12.1-.21.23-.25.38h1.37c-.05-.15-.14-.28-.26-.38-.12-.09-.27-.15-.42-.14Z" style="fill:#00369c; stroke-width:0px;"/><path d="M4.78,9.9c.02.31.28.54.58.53.28-.01.51-.24.53-.53h-1.11Z" style="fill:#00369c; stroke-width:0px;"/><path d="M4.83,10.77h1v3.28h-1v-3.28Z" style="fill:#00369c; stroke-width:0px;"/><path d="M32.69,11.6v-.84h-.92v-.87l-.66.14c-.02.12-.07.24-.14.35-.13.22-.35.37-.6.42-.01,0-.03,0-.04,0v.8h.43v1.44c-.02.29.09.58.3.78.2.18.5.26.89.26.12,0,.24-.01.35-.03.12-.01.23-.04.35-.07v-.81c-.07.02-.15.04-.23.05-.07.01-.15.02-.22.02-.12.01-.24-.02-.34-.09-.07-.08-.11-.2-.1-.31v-1.25h.92Z" style="fill:#3ec92b; stroke-width:0px;"/><path d="M17.45,13.24c.13,0,.26-.03.38-.09.13-.07.24-.16.33-.27l.59.62c-.17.19-.37.34-.61.44-.24.1-.49.16-.75.16-.23,0-.47-.04-.68-.13-.64-.26-1.06-.88-1.05-1.57,0-.23.04-.46.13-.67.08-.2.21-.39.37-.54.33-.32.78-.5,1.24-.49.26,0,.53.05.77.16.24.1.45.25.62.45l-.61.64c-.1-.12-.22-.21-.35-.28-.12-.06-.26-.09-.4-.09-.21,0-.41.09-.54.24-.15.16-.23.38-.22.59,0,.22.08.43.23.59.14.16.35.24.56.24h0Z" style="fill:#3ec92b; stroke-width:0px;"/><path d="M19.04,14.04v-3.28h1v.33c.1-.12.23-.23.38-.3.15-.07.32-.11.48-.11.08,0,.15,0,.23.02.05,0,.1.03.15.06v.87c-.07-.03-.15-.05-.22-.07-.08-.02-.17-.03-.25-.03-.15,0-.3.04-.44.11-.13.07-.24.18-.33.3v2.08h-1Z" style="fill:#3ec92b; stroke-width:0px;"/><path d="M22.58,9.9c.01.31.27.54.58.53.29-.01.51-.24.53-.53h-1.11Z" style="fill:#3ec92b; stroke-width:0px;"/><path d="M24.6,13.61c-.19.16-.4.29-.64.38-.24.08-.48.12-.73.12-.24,0-.48-.04-.7-.13-.42-.16-.76-.49-.94-.9-.09-.21-.14-.44-.14-.67,0-.23.04-.46.13-.67.08-.2.21-.39.36-.54.16-.15.34-.28.54-.36.21-.09.44-.13.67-.13.45,0,.88.18,1.19.51.15.16.27.36.34.57.08.23.13.47.12.72v.25h-2.34c.07.15.17.28.31.37.15.1.32.15.5.15.13,0,.25-.02.37-.07.11-.04.2-.1.28-.18l.66.59ZM23.14,11.53c-.15,0-.3.04-.43.14-.12.1-.21.23-.25.38h1.37c-.05-.15-.14-.28-.26-.38-.12-.09-.27-.15-.42-.14h0Z" style="fill:#3ec92b; stroke-width:0px;"/><path d="M27.62,14.04v-.24c-.13.09-.27.16-.42.21-.15.05-.31.07-.46.07-.22,0-.45-.04-.65-.13-.2-.08-.38-.21-.53-.36-.15-.15-.27-.34-.36-.54-.09-.21-.13-.43-.13-.66,0-.23.04-.45.13-.66.17-.4.5-.72.9-.89.35-.14.74-.17,1.11-.07.14.04.27.09.4.16v-.82l1-.22v4.14h-.99ZM26.06,12.4c0,.22.09.44.25.59.16.16.38.24.61.24.13,0,.26-.02.38-.06.12-.04.22-.11.31-.2v-1.15c-.09-.08-.2-.14-.31-.19-.12-.05-.25-.07-.38-.07-.23,0-.45.08-.61.24-.16.15-.25.37-.25.59h0Z" style="fill:#3ec92b; stroke-width:0px;"/><path d="M28.97,9.9c.01.31.27.54.58.53.29-.01.51-.24.53-.53h-1.11Z" style="fill:#3ec92b; stroke-width:0px;"/><path d="M29.02,10.77h1v3.28h-1v-3.28Z" style="fill:#3ec92b; stroke-width:0px;"/><path d="M35.9,11.7c-.08-.03-.16,0-.2.08,0,0,0,0,0,0l-.19.45c.01.06.02.12.02.18,0,.22-.08.43-.23.59-.3.31-.8.32-1.11.02,0,0-.02-.01-.02-.02-.31-.33-.31-.85,0-1.18.3-.31.8-.32,1.11-.02,0,0,.02.02.02.02.05.05.09.1.12.16l.12-.27c.07-.17.27-.25.45-.18,0,0,0,0,0,0l.36.16c-.09-.18-.21-.35-.35-.49-.16-.16-.35-.28-.56-.36-.45-.18-.95-.18-1.39,0-.21.08-.4.21-.56.36-.16.15-.29.34-.38.54-.19.42-.19.91,0,1.33.09.2.22.39.38.54.16.16.35.28.56.36.45.17.95.17,1.39,0,.21-.08.4-.2.56-.36.16-.15.29-.34.38-.54.09-.21.14-.44.14-.67,0-.16-.02-.32-.07-.47l-.53-.23Z" style="fill:#3ec92b; stroke-width:0px;"/></g></svg>

<br>
<!-- TODO: insert your icon here -->
<YOUR SVG CODE>
</br

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name) @gomonke

What's the expected date of this change to deploy on Shopify? 04/15/2024

@adeniyiao
Copy link
Contributor

Hi @gomonke ,

Kindly address the test failure below

{:message=>"The 'sistecredito' SVG file does not have the appropriate <title> value"}.
Expected: "Sistecredito"
  Actual: "sistecredito"

@gomonke
Copy link
Contributor Author

gomonke commented Jun 4, 2024

Hi @gomonke ,

Kindly address the test failure below

{:message=>"The 'sistecredito' SVG file does not have the appropriate <title> value"}.
Expected: "Sistecredito"
  Actual: "sistecredito"

Hi @adeniyiao , title is changed

@dannye0231
Copy link
Contributor

@gomonke can you please re-base?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lydia-shan-git Lydia-shan-git Awaiting requested review from Lydia-shan-git

Assignees
No one assigned
Labels
Changes Requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gomonke @adeniyiao @dannye0231 @Lovedanihonjin