Revert "[all OSs] Pin Rust to 1.89.0 due to a 1.90.0 breaking change" #13076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous change that pinned Rust to version 1.89.0, returning to using the stable channel across all operating systems. The change addresses a resolved breaking change that was introduced in Rust 1.90.0.
- Removes explicit Rust version pinning from 1.89.0
- Returns to using the stable toolchain channel
- Updates all three platform-specific installation scripts
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| images/windows/scripts/build/Install-Rust.ps1 | Updates Windows Rust installation to use stable toolchain instead of 1.89.0 |
| images/ubuntu/scripts/build/install-rust.sh | Updates Ubuntu Rust installation to use stable toolchain instead of 1.89.0 |
| images/macos/scripts/build/install-rust.sh | Updates macOS Rust installation to use stable toolchain instead of 1.89.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Alexey-Ayupov
approved these changes
Sep 24, 2025
dwydler
pushed a commit
to dwydler/runner-images-hetzner-cloud
that referenced
this pull request
Sep 26, 2025
…ctions#13044)" (actions#13076) This reverts commit 98a1416.
slight correction here - Copilot didn't "review" anything, it merely extruded word salad superficially resembling a code review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #13044