Skip to content

fixed input field not updated after item click #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed input field not updated after item click #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/PlaceAutocompleteField.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div class="autocomplete-field" @keydown="onKeydown" @keyup="onKeyup">
<input-field
<input
v-model="query"
v-bind-events
v-bind="$attrs"
Expand All @@ -11,9 +11,8 @@
autocomplete="no"
@blur="onBlur"
@focus="onFocus"
@input="$emit('input', query)">
<activity-indicator v-if="showActivityIndicator" size="xs" type="spinner"/>
</input-field>
@input="$emit('input', query)" />
<activity-indicator v-if="showActivityIndicator" size="xs" type="spinner"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did the closing input tag go?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is on line 14 at the end, do you want it on a new line?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, never mind.

I'm using https://github.com/ds300/patch-package to patch it myself for now since I think these PR's are gonna sit for sometime and maybe this project is somewhat abandoned. Thanks!

<place-autocomplete-list v-if="predictions && showPredictions" :items="predictions" @item:click="onItemClick" @item:blur="onItemBlur"/>
</div>
</template>
Expand Down