improve(proposer): Update proposal log format #2607
Conversation
This log message can be pretty difficult to read in Slack. Prioritise logging fields that are sought the most often.
pxrl
requested review from
bmzig,
dohaki,
james-a-morris,
mrice32 and
nicholaspai
as code owners
src/dataworker/PoolRebalanceUtils.ts
Outdated
| bundleLpFees, | ||
| groupId, | ||
| }; | ||
| poolRebalanceLeavesPretty += `\n\t\t\t${index}: ${JSON.stringify(orderedLeaf)}`; |
There was a problem hiding this comment.
I'm mulling over some ideas about how this might be improved even further. I'd like to get this in as-is, but we might circle back with another change too.
|
nb currently looks like the screenshots below. There are some issues:
It seems like we'll at least need to split the current single log message into:
We will probably also need to split the logs for relayer refund leaves into smaller chunks to avoid splitting them over multiple Slack messages. 
|
* feat: add atomic depositor entrypoint for OFT bridges Signed-off-by: bennett <[email protected]> * import bridge Signed-off-by: bennett <[email protected]> * update Signed-off-by: bennett <[email protected]> * comment Signed-off-by: bennett <[email protected]> * use big number Signed-off-by: bennett <[email protected]> --------- Signed-off-by: bennett <[email protected]>
Do you plan on addressing the issue about a table being split over multiple messages in this PR? |
Yeah; so far I am splitting the existing single message into bundle blocks, pool rebalance leaves, relayer refund leaves and slow fill leaves. I think the relayer refund leaves will need to be chunked into smaller messages again, though. |
This log message can be pretty difficult to read in Slack. Prioritise logging fields that are sought the most often.