fix(ProfitClient): Fix fill amount USD computation #1688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ProfitClient currently assumes that the value of a fill can be determined from the input token price * the output amount of the output token. This is roughly correct for most Across deposits, but falls over when the deposit includes an in-protocol swap to an output token with a different number of decimals. This was exposed on an Optimism deposit for inputToken USDC, outputToken AERO on Base. Deposit hash: 0x4a3febcfb764467d9eae261b3a3938137db383289fe328050a2871eb407e1147
pxrl
requested review from
james-a-morris,
mrice32 and
nicholaspai
as code owners
pxrl
commented
Jul 19, 2024
nicholaspai
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
https://github.com/across-protocol/relayer/pull/1688/files#r1684522349
LGTM if my understanding here is correct
ishantiw
pushed a commit
to LiskHQ/across-relayer
that referenced
this pull request
Aug 8, 2024
) The ProfitClient currently assumes that the value of a fill can be determined from the input token price * the output amount of the output token. This is roughly correct for most Across deposits, but falls over when the deposit includes an in-protocol swap to an output token with a different number of decimals. This was exposed on an Optimism deposit for inputToken USDC, outputToken AERO on Base. Deposit hash: 0x4a3febcfb764467d9eae261b3a3938137db383289fe328050a2871eb407e1147
ishantiw
pushed a commit
to LiskHQ/across-relayer
that referenced
this pull request
Aug 8, 2024
) The ProfitClient currently assumes that the value of a fill can be determined from the input token price * the output amount of the output token. This is roughly correct for most Across deposits, but falls over when the deposit includes an in-protocol swap to an output token with a different number of decimals. This was exposed on an Optimism deposit for inputToken USDC, outputToken AERO on Base. Deposit hash: 0x4a3febcfb764467d9eae261b3a3938137db383289fe328050a2871eb407e1147
sameersubudhi
pushed a commit
to LiskHQ/across-relayer
that referenced
this pull request
Sep 10, 2024
) The ProfitClient currently assumes that the value of a fill can be determined from the input token price * the output amount of the output token. This is roughly correct for most Across deposits, but falls over when the deposit includes an in-protocol swap to an output token with a different number of decimals. This was exposed on an Optimism deposit for inputToken USDC, outputToken AERO on Base. Deposit hash: 0x4a3febcfb764467d9eae261b3a3938137db383289fe328050a2871eb407e1147
sameersubudhi
pushed a commit
to LiskHQ/across-relayer
that referenced
this pull request
Sep 10, 2024
) The ProfitClient currently assumes that the value of a fill can be determined from the input token price * the output amount of the output token. This is roughly correct for most Across deposits, but falls over when the deposit includes an in-protocol swap to an output token with a different number of decimals. This was exposed on an Optimism deposit for inputToken USDC, outputToken AERO on Base. Deposit hash: 0x4a3febcfb764467d9eae261b3a3938137db383289fe328050a2871eb407e1147
sameersubudhi
pushed a commit
to LiskHQ/across-relayer
that referenced
this pull request
Sep 10, 2024
) The ProfitClient currently assumes that the value of a fill can be determined from the input token price * the output amount of the output token. This is roughly correct for most Across deposits, but falls over when the deposit includes an in-protocol swap to an output token with a different number of decimals. This was exposed on an Optimism deposit for inputToken USDC, outputToken AERO on Base. Deposit hash: 0x4a3febcfb764467d9eae261b3a3938137db383289fe328050a2871eb407e1147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ProfitClient currently assumes that the value of a fill can be determined from the input token price * the output amount of the output token. This is roughly correct for most Across deposits, but falls over when the deposit includes an in-protocol swap to an output token with a different number of decimals.
This was exposed on an Optimism deposit for inputToken USDC, outputToken AERO on Base.
Deposit hash:
0x4a3febcfb764467d9eae261b3a3938137db383289fe328050a2871eb407e1147