feat: send cctp burn transactions to pubsub #391
Conversation
| await this.pubSubService.publishCctpFinalizerMessage( | ||
| transactionHash, | ||
| Number(chainId), | ||
| ); |
There was a problem hiding this comment.
So if this succeeds but the Cloud Run service fails for some reason, we will still update the CctpFinalizerJob table below right? Will it still retry in this case?
There was a problem hiding this comment.
No, it won't retry. I will have a follow up PR which will check periodically for unfinalized old events
| const qb = this.postgres | ||
| .createQueryBuilder(DepositForBurn, "burnEvent") | ||
| .leftJoinAndSelect("burnEvent.finalizerJob", "job") | ||
| .where("job.id IS NULL") |
There was a problem hiding this comment.
Just trying to understand - when would job.id be null? Won't it be auto-incremented when the insert happens below?
There was a problem hiding this comment.
Exactly, but we search for burn events that don't have a job associated yet. Therefore we need to execut a LEFT JOIN where job's id is NULL (i.e doesn't exist)
| indexingDelaySeconds: | ||
| getIndexingDelaySeconds(chainId, this.config) * 2, |
There was a problem hiding this comment.
indexing CCTP events is much fast than SpokePool events via the SDK, so we can increase the delay a bit here
amateima
force-pushed
the
amatei/acx-4576-send-burn-txns-to-finalization-bot
branch
from
bb2a4aa to
c894c13
Compare
amateima
requested review from
dohaki,
melisaguevara,
mrice32 and
nicholaspai
as code owners
| const topic = await this.pubSub.topic( | ||
| this.config.pubSubCctpFinalizerTopic, | ||
| ); |
There was a problem hiding this comment.
this.pubSub.topic() is not an async function right? Do we need the await?
| /** | ||
| * @notice Returns the CCTP domain for a given chain ID. Throws if the chain ID is not a CCTP domain. | ||
| * @param chainId | ||
| * @returns CCTP Domain ID | ||
| */ | ||
| export function getCctpDomainForChainId(chainId: number): number { | ||
| const cctpDomain = PUBLIC_NETWORKS[chainId]?.cctpDomain; | ||
| if (!across.utils.isDefined(cctpDomain) || cctpDomain === CCTP_NO_DOMAIN) { | ||
| throw new Error(`No CCTP domain found for chainId: ${chainId}`); | ||
| } | ||
| return cctpDomain; | ||
| } | ||
|
|
There was a problem hiding this comment.
This same function and fetchAttestationsForTxn is being used in the finalizer service too. Maybe we can consolidate in the SDK later.
There was a problem hiding this comment.
Yes @ashwinrava. Nick just merged a PR with CCTP utils which is going to be integrated soon in the indexer 👍
| const attestations = await fetchAttestationsForTxn( | ||
| getCctpDomainForChainId(Number(burnEvent.chainId)), | ||
| transactionHash, | ||
| true, |
There was a problem hiding this comment.
Would we ever need to handle testnets?
There was a problem hiding this comment.
you mean that getCctpDomainForChainId function doesn't handle testnets?
There was a problem hiding this comment.
I mean true is being passed to the isMainnet field on line 147. In the finalizer service I call chainIsProd(sourceChainId) and then pass that value to fetchAttestationsForTxn. Just thinking if we need to do something similar here.
2 participants
This PR implements a new service that publishes CCTP (Cross-Chain Transfer Protocol) burn events to a GCP PubSub topic, enabling the finalization bot to process and finalize these transactions onchain.
Changes
Database Layer
CctpFinalizerJob- Tracks burn events that have been successfully sent to the finalizer botService Layer
CctpFinalizerService- Core service that runs on an intervalCctpFinalizerJobrecords to track published eventsIntegration Layer
Configuration
ENABLE_CCTP_FINALIZER- Feature flag to enable/disable the serviceCCTP_FINALIZER_PUBSUB_TOPIC- GCP PubSub topic URL for publishing messages