feat: Added OP foundry deploy script #1131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fusmanii
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
nicholaspai
previously approved these changes
Oct 7, 2025
pxrl
reviewed
Oct 8, 2025
script/025DeployOPSpokePool.s.sol
Outdated
| "OP_SpokePool", | ||
| constructorArgs, | ||
| initArgs, | ||
| true // implementationOnly |
There was a problem hiding this comment.
We might want to read this from the environment, or try to infer it from existing config. If they find a proxy then they skip deploying a new one, and otherwise they deploy both implementation and proxy.
There was a problem hiding this comment.
that is already being done here upstream, this flag is just for when we want to forcefully deploy the implementation only
There was a problem hiding this comment.
set the flag to false 0625b2f
script/025DeployOPSpokePool.s.sol
Outdated
Comment on lines
12
to
15
| // 2. forge script script/039DeployOPSpokePool.s.sol:DeployOPSpokePool --rpc-url $NODE_URL_1 -vvvv | ||
| // 3. Verify the above works in simulation mode. | ||
| // 4. Deploy with: | ||
| // forge script script/039DeployOPSpokePool.s.sol:DeployOPSpokePool --rpc-url \ |
There was a problem hiding this comment.
Minor:
Suggested change
| // 2. forge script script/039DeployOPSpokePool.s.sol:DeployOPSpokePool --rpc-url $NODE_URL_1 -vvvv | |
| // 3. Verify the above works in simulation mode. | |
| // 4. Deploy with: | |
| // forge script script/039DeployOPSpokePool.s.sol:DeployOPSpokePool --rpc-url \ | |
| // 2. forge script script/025DeployOPSpokePool.s.sol:DeployOPSpokePool --rpc-url $NODE_URL_1 -vvvv | |
| // 3. Verify the above works in simulation mode. | |
| // 4. Deploy with: | |
| // forge script script/025DeployOPSpokePool.s.sol:DeployOPSpokePool --rpc-url \ |
Signed-off-by: Faisal Usmani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was missing as part of #1087