Remove legacy address-to-bytes32 compatibility tests #1129
+0
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashaodessa
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes outdated legacy tests and functions that were used to verify compatibility between the old address format and the new bytes32 format during the SpokePool upgrade. Since the migration to bytes32 format has been completed, these compatibility checks are no longer needed.
Changes Made
SpokePool.Relay.tsthat verified relay hash compatibility between address and bytes32 formatsMerkleLib.Proofs.tsthat verified Merkle leaf compatibility between address and bytes32 formatsgetLegacyV3RelayHashfromSpokePool.Fixture.tsthat was used for address-format relay hashinggetLegacyV3RelayHash,bytes32ToAddress) that are no longer neededWhy This Change
The SpokePool contracts have already been upgraded to use the new bytes32 format with
AddressConverterslibrary. The legacy compatibility tests were marked with@todocomments indicating they could be removed after the upgrade, which has now been completed.This cleanup removes ~60 lines of dead code and eliminates misleading TODO comments that referenced a completed migration.