Skip to content

chore: Bump node 16 (20) -> 22 #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 27, 2025
Merged

chore: Bump node 16 (20) -> 22 #1065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b372395
chore: Drop Linea SDK dependency
pxrl Aug 14, 2025
7cb7743
chore: Bump node 16 -> 22
pxrl Aug 14, 2025
71ba686
Tighten version check
pxrl Aug 14, 2025
207e90c
Simplify check
pxrl Aug 14, 2025
73b6e4f
chore: Bump kit 2.1.0 -> 2.3.0
pxrl Aug 14, 2025
6c61f5d
Merge remote-tracking branch 'origin/master' into pxrl/bumpNode
pxrl Aug 14, 2025
6c8733b
Revert "chore: Bump kit 2.1.0 -> 2.3.0"
pxrl Aug 14, 2025
2dc7bc2
Merge remote-tracking branch 'origin/master' into pxrl/bumpNode
pxrl Aug 26, 2025
8958540
Bump to 22.18
pxrl Aug 26, 2025
121e675
Bump node
pxrl Aug 26, 2025
3576720
Revert "Bump node"
pxrl Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup-node-if-needed/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ runs:
id: check-node
shell: bash
run: |
if command -v node >/dev/null 2>&1; then
if node --version 2>/dev/null | grep -q "v${{ inputs.node_version }}"; then
Copy link
Contributor Author

@pxrl pxrl Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pre-existing check would resolve true if the installed version of node was different to what was specified via inputs.node_version. Harden it a bit by verifying that the actual installed version of node reports something that gives a strong hint at being the right version. This should be compatible with specifying additional constraints on the version - i.e. minor and patch levels.

I wonder if there's a cleaner way to do this - i.e. I'd suspect setup-node has some built-in version checker, but since action was only recently by @Reinis-FRP I'm assuming there was some blocker there.

echo "installed=true" >> "$GITHUB_OUTPUT"
else
echo "installed=false" >> "$GITHUB_OUTPUT"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
branches:
- "master"
env:
NODE_VERSION: 20
NODE_VERSION: 22.18
jobs:
# Multiple jobs depend on having EVM and SVM artifacts available, so we upload them first in separate jobs.
upload-svm-artifacts:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:
permissions:
contents: write
env:
NODE_VERSION: "20.x"
NODE_VERSION: 22.18
EVM_ARTIFACTS_PATHS: |
artifacts
cache
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"url": "git+https://github.com/across-protocol/across-smart-contracts-v2.git"
},
"engines": {
"node": ">=16.18.0"
"node": ">=22.18.0"
},
"files": [
"/contracts/**/*.sol",
Expand Down