Interface headerProps intermediate variable #1127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the Kazuya Gosho's projects Team on Vercel. A member of the Team first needs to authorize it. |
winie
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Sorry for my slow response and thank you for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type information would be added for the headerProps intermediate variable in the CalendarContainer component. But not for the month mode, because in this mode the header is implemented with the CalendarHeaderForMonthView component. A new interface HeaderRendererProps was created for this purpose, which summarises the CalendarHeaderProps and the type of the mode property.
I'm not entirely sure that the changes to the types are 100% correct or even necessary. Please check before merging.