Add locale property to CalendarHeaderProps interface #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the Kazuya Gosho's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@winie Good catch! Thank you for your contribution. |
|
Released on v4.15.1 |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, I would like to thank you for providing this component. We use it in our open source project, which is an app for our students.
I have added the locale property to the CalendarHeaderProps interface. In the _CalendarContainer component (currently on line 377) the locale value is stored in the headerProps constant. The headerProps constant is later transferred to the HeaderComponent component as properties. If a custom header renderer is programmed, the calendar transfers the desired language. In my humble opinion, this is good software design.
Unfortunately, you first have to read the code to recognize this fact, because the locale property is missing in the CalendarHeaderProps interface. Otherwise you could already recognize the transfer of the language in the CalendarHeaderProps interface.