Replace hyphen with underscore in ahSettingsFile (#86) #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danepowell
requested changes
Jun 25, 2024
Co-authored-by: Dane Powell <[email protected]>
|
Thank you @danepowell. I learned str_replace can accept arrays for search and/or replace. |
|
Thanks. I think there's a CI outage right now but I'll circle back to this tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
#86
Motivation
Acquia Cloud does not support hyphens in db names. FilePaths::ahSettingsFile handles periods but not hyphens.
Proposed changes
Ensure FilePaths::ahSettingsFile return the correct settings file when a site_name contains a hyphen
Alternatives considered
A hyphen is valid character in domain names.
Testing steps
Add a multisite with a hyphen in the name to a project on Acquia Cloud using Acquia Recommended Settings.
example: childrens-school.domain.com