Update ORCA to alpha18. #3712

danepowell · 2019-06-13T19:26:31Z

https://github.com/acquia/orca/releases/tag/v1.0.0-alpha17

This is awesome because we should get full deprecation testing now.

Blocked by:

Task: general code style cleanup #3627 to fix code style errors
Fix broken deprecation tests #3738 to fix deprecation tests
Figure out what to do about deprecated Behat context: SnippetAcceptingContext is deprecated jhedstrom/drupalextension#537
Ignore deprecation of AnnotationsRegistry orca#27 to fix other deprecation tests
alpha17 release of ORCA to fix overzealous code style scanning (i.e. MD files)
Update coding-standards dependency version to match ORCA dependency in ~~alpha17~~ whatever version includes the library
Think about removing native PHPCS checks from BLT, since they would now duplicate ORCA.
Remove version constraint mglaman/phpstan-drupal": "0.11.7" introduced in Fixes #3738: Failing deprecation tests. #3739
Update to Symfony 4.x if we can to work around a deprecation scanning bug with ORCA

danepowell · 2019-07-08T16:49:46Z

Alpha17 out now, should also fix phpstan neon issues: https://github.com/acquia/orca/releases/tag/v1.0.0-alpha17

danepowell · 2019-07-08T22:58:13Z

@TravisCarden do you have a timeline for releasing a new ORCA version that uses the shared Coding Standards library rather than ORCA's built-in standards? I think this will be necessary to get the static analysis tests passing here, since we developed to the shared standards rather than ORCA's (they are slightly different).

TravisCarden · 2019-07-09T14:33:49Z

@danepowell I'm working on a release as we speak. I'm hoping to get it out today. I'll let you know.

TravisCarden · 2019-07-09T18:08:57Z

All right, @danepowell. v1.0.0-alpha18, using our shared coding standards library, is out now!

This reverts commit a034700.

danepowell · 2019-07-09T22:34:20Z

Just one final bug to squash before we can merge this.

@TravisCarden I think ORCA is erroneously throwing a deprecation error here: https://travis-ci.com/acquia/blt/jobs/214613419#L2026

Notice that BLT uses symfony/config 3.4.29, and in that version the function BLT is calling is not deprecated, so I don't think ORCA should be throwing this error.

This is just a guess, but I wonder if ORCA itself uses Symfony Config 4+ and that's why it's throwing an error (even though the SUT in this case uses Symfony Config 3).

TravisCarden · 2019-07-11T14:27:34Z

You're right, @danepowell: ORCA uses Symfony Config 4.3. I wonder if that constitutes a bug in phpstan. In any case, I'll see what I can do about it.

danepowell · 2019-07-12T20:42:10Z

I confirmed locally that if you use ORCA's phpstan binary, it causes this false positive. If you use BLT's phpstan binary, it works fine (even for the same version of phpstan).

I think what's happening here is that phpstan is autoloading from its own directory, which means that it autoloads the wrong version of symfony for deprecation testing. You can confirm this by unceremoniously killing ORCA's symfony config: rm -rf vendor/symfony/config/

After that tests will pass.

TravisCarden · 2019-07-16T18:35:24Z

@danepowell I've worked around the issue in acquia/orca#33. I can't merge the change yet because it will cause my builds to fail until you unpin from mglaman/phpstan-drupal:0.11.7 and cut a new release. So you can test this per usual:

diff --git a/.travis.yml b/.travis.yml
index ce2dc757..ba35f8ae 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -58,6 +58,7 @@ before_install:
   # Install ORCA.
   - git clone --branch ${ORCA_VERSION} --depth 1 https://github.com/acquia/orca.git ../orca
   - curl https://patch-diff.githubusercontent.com/raw/acquia/orca/pull/30.patch | git -C ../orca apply
+  - curl https://patch-diff.githubusercontent.com/raw/acquia/orca/pull/33.patch | git -C ../orca apply
   - ../orca/bin/travis/before_install.sh

 install:

My local testing indicates that you'll still have at least one problem to work out, but it works like before on the other packages I tested with, and I think based on that and the failure itself (see below) that the problem will have to be addressed in BLT. In other words, the ball is in your court. :)

$ orca phpstan --sut=acquia/blt
> '/Users/travis.carden/Projects/acquia/orca-build/vendor/bin/phpstan' 'analyse' '--configuration=/Users/travis.carden/Projects/acquia/orca/src/Task/DeprecatedCodeScanner/phpstan.neon' '--autoload-file=/Users/travis.carden/Projects/acquia/orca-build/docroot/autoload.php' '/Users/travis.carden/Projects/acquia/orca-build/vendor/acquia/blt'
  70/181 [▓▓▓▓▓▓▓▓▓▓░░░░░░░░░░░░░░░░░░]  38%
Fatal error: During class fetch: Uncaught PHPStan\Broker\ClassAutoloadingException: Class Composer\Plugin\PluginInterface not found and could not be autoloaded. in /Users/travis.carden/Projects/acquia/orca-build/vendor/phpstan/phpstan/src/Broker/Broker.php:358
Stack trace:
#0 [internal function]: PHPStan\Broker\Broker->PHPStan\Broker\{closure}('Composer\\Plugin...')
#1 /Users/travis.carden/Projects/acquia/blt/src/Composer/Plugin.php(23): spl_autoload_call('Composer\\Plugin...')
#2 /Users/travis.carden/Projects/acquia/orca-build/vendor/composer/ClassLoader.php(444): include('/Users/travis.c...')
#3 /Users/travis.carden/Projects/acquia/orca-build/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('/Users/travis.c...')
#4 [internal function]: Composer\Autoload\ClassLoader->loadClass('Acquia\\Blt\\Comp...')
#5 [internal function]: spl_autoload_call('Acquia\\Blt\\Comp...')
#6 /Users/travis.carden/Projects/acquia/orca-build/vendor/phpstan/phpstan/src/Broker/Broker.php(363): class_exists('Acquia\\Blt\\Comp...')
 in /Users/travis.carden/Projects/acquia/blt/src/Composer/Plugin.php on line 23
PHP Fatal error:  During class fetch: Uncaught PHPStan\Broker\ClassAutoloadingException: Class Composer\Plugin\PluginInterface not found and could not be autoloaded. in /Users/travis.carden/Projects/acquia/orca-build/vendor/phpstan/phpstan/src/Broker/Broker.php:358
Stack trace:
#0 [internal function]: PHPStan\Broker\Broker->PHPStan\Broker\{closure}('Composer\\Plugin...')
#1 /Users/travis.carden/Projects/acquia/blt/src/Composer/Plugin.php(23): spl_autoload_call('Composer\\Plugin...')
#2 /Users/travis.carden/Projects/acquia/orca-build/vendor/composer/ClassLoader.php(444): include('/Users/travis.c...')
#3 /Users/travis.carden/Projects/acquia/orca-build/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('/Users/travis.c...')
#4 [internal function]: Composer\Autoload\ClassLoader->loadClass('Acquia\\Blt\\Comp...')
#5 [internal function]: spl_autoload_call('Acquia\\Blt\\Comp...')
#6 /Users/travis.carden/Projects/acquia/orca-build/vendor/phpstan/phpstan/src/Broker/Broker.php(363): class_exists('Acquia\\Blt\\Comp...')
 in /Users/travis.carden/Projects/acquia/blt/src/Composer/Plugin.php on line 23

danepowell · 2019-07-17T17:45:28Z

Upstream issue on the off-chance that there's some better way to work around this than to directly require composer/composer into the fixture: phpstan/phpstan#2305

Update ORCA to alpha15.

f98b110

alexxed approved these changes Jun 21, 2019

View reviewed changes

adrianthedev approved these changes Jun 21, 2019

View reviewed changes

Merge branch '10.x' into orca-15

632d421

danepowell mentioned this pull request Jun 25, 2019

Use AcquiaDrupalStrict coding standards #3726

Merged

danepowell changed the title ~~Update ORCA to alpha15.~~ Update ORCA to alpha17. Jun 25, 2019

danepowell added 3 commits July 1, 2019 12:33

Merge branch '10.x' into orca-15

6cece88

Updated to orca16.

1835f86

Composer updates.

ee03473

danepowell force-pushed the orca-15 branch from 34967cf to ee03473 Compare July 1, 2019 20:20

Fixing tests.

9342f07

danepowell mentioned this pull request Jul 1, 2019

Fixes #3738: Failing deprecation tests. #3739

Merged

Attempt to fix deprecation errors for annotationregistry.

d911abf

danepowell added 4 commits July 8, 2019 15:23

Merge branch '10.x' into orca-15

1a182b8

Updated ORCA to alpha17.

296d3f9

Removed unneeded patch.

183a51f

Removed constraints on nette and mglaman.

94f282b

danepowell added 6 commits July 9, 2019 13:24

Updated ORCA to alpha18.

27add03

Fixed phpcs security audit tests.

2768ee3

Removed deprecated behat context.

f673f0b

Use symfony/config 4.

a034700

Removed unused context.

3a11be5

Revert "Use symfony/config 4."

ddfeac1

This reverts commit a034700.

TravisCarden mentioned this pull request Jul 16, 2019

Fix potential Phpstan autoloader conflicts leading to incorrect deprecation scan results acquia/orca#33

Merged

danepowell added 5 commits July 16, 2019 12:43

Fixed deprecation issue.

a65bedf

Make composer a production dependency since it's used in plugin.

19283cb

Fixed deprecated calls to RoboConfig::import.

79d09de

Merge branch '10.x' into orca-15

540524b

Composer back to dev dependency.

d884818

danepowell force-pushed the orca-15 branch 3 times, most recently from 0e0a5ce to 7edc9e4 Compare July 17, 2019 17:29

Fixed problem with PHPStan.

3379226

danepowell force-pushed the orca-15 branch from 7edc9e4 to 3379226 Compare July 17, 2019 17:34

danepowell changed the title ~~Update ORCA to alpha17.~~ Update ORCA to alpha18. Jul 17, 2019

danepowell merged commit 498f73e into acquia:10.x Jul 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ORCA to alpha18. #3712

Update ORCA to alpha18. #3712

danepowell commented Jun 13, 2019 •

edited

Loading

danepowell commented Jul 8, 2019

danepowell commented Jul 8, 2019

TravisCarden commented Jul 9, 2019

TravisCarden commented Jul 9, 2019

danepowell commented Jul 9, 2019 •

edited

Loading

TravisCarden commented Jul 11, 2019

danepowell commented Jul 12, 2019 •

edited

Loading

TravisCarden commented Jul 16, 2019

danepowell commented Jul 17, 2019

Update ORCA to alpha18. #3712

Update ORCA to alpha18. #3712

Conversation

danepowell commented Jun 13, 2019 • edited Loading

danepowell commented Jul 8, 2019

danepowell commented Jul 8, 2019

TravisCarden commented Jul 9, 2019

TravisCarden commented Jul 9, 2019

danepowell commented Jul 9, 2019 • edited Loading

TravisCarden commented Jul 11, 2019

danepowell commented Jul 12, 2019 • edited Loading

TravisCarden commented Jul 16, 2019

danepowell commented Jul 17, 2019

danepowell commented Jun 13, 2019 •

edited

Loading

danepowell commented Jul 9, 2019 •

edited

Loading

danepowell commented Jul 12, 2019 •

edited

Loading