Fixes #1543: Twig Lint is not maintained and fails valid twig code. #2151

wu-edward · 2017-10-18T00:53:56Z

Changes proposed:

Remove asm89/twig-lint and use Symfony twig linter
Run twig lint command procedurally instead of in parallel, otherwise error messages are suppressed.
Account for Twig functions and filters added by Drupal, so that linter does not flag as invalid.
Provide config for users to add custom Twig filters and functions that can be specified in project.yml
Reorder precommit lint commands so that PHPUnit tests do not fail on Travis.

grasmash · 2017-10-18T03:13:29Z

src/Robo/Commands/Git/GitCommand.php

    $this->invokeCommands([
+      // Passing a file list to be PHPCS will cause all specified files to


We don't need to add this comment back :)

I refactored and removed all the changes to this class.

grasmash · 2017-10-18T03:16:24Z

src/Robo/Blt.php

+   *
+   * @param \Acquia\Blt\Robo\Application $application
+   */
+  protected function addSymfonyCommands(Application $application) {


I do wish we could move this out of the Blt.php file. It feels like it doesn't belong here.

I agree, so I refactored and put everything in the TwigCommand class. I think it's cleaner now.

…o ignore.

grasmash added the in progress label Oct 18, 2017

wu-edward mentioned this pull request Oct 18, 2017

Issue 1543 twig lint replacement #2062

Closed

grasmash reviewed Oct 18, 2017

View reviewed changes

Edward Wu added 3 commits October 18, 2017 09:31

Remove twig-lint and add Symfony twig-bridge.

8e04a3c

Add default config for custom Twig filters and functions for linter t…

026ac5e

…o ignore.

Update documentation for adding custom Twig function and filters.

61dd980

wu-edward force-pushed the issue-1543 branch from a30795a to 8d232a0 Compare October 18, 2017 16:32

Replace twig-lint with Symfony LintCommand.

3f74f97

wu-edward force-pushed the issue-1543 branch from 8d232a0 to 3f74f97 Compare October 18, 2017 16:41

grasmash added the Enhancement A feature or feature request label Oct 18, 2017

grasmash merged commit 96dba3a into acquia:9.1.x Oct 18, 2017

grasmash removed the in progress label Oct 18, 2017

grasmash changed the title ~~Issue 1543~~ Fixes #1543: Twig Lint is not maintained and fails valid twig code. Oct 18, 2017

wu-edward deleted the issue-1543 branch September 10, 2018 15:29

Provide feedback

		$this->invokeCommands([
		// Passing a file list to be PHPCS will cause all specified files to