-
Notifications
You must be signed in to change notification settings - Fork 367
Create acl-anthology release v0.5.4 #6653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6653 +/- ##
==========================================
+ Coverage 92.03% 93.76% +1.72%
==========================================
Files 35 35
Lines 2850 2853 +3
==========================================
+ Hits 2623 2675 +52
+ Misses 227 178 -49
🚀 New features to boost your workflow:
|
f7e41f8 to
111694c
Compare
|
Ugh, the MacOS build error was painful to debug. Turns out that the Poetry action uses the system Python rather than the version specified in the runner, so it was trying to install Scipy via Python 3.14 even though we currently only test with 3.10–3.13. I followed the solution in abatilo/actions-poetry#72 and squashed my 7 commits that were trying to get this to work... (I should put "Python 3.14 support" on my list of TODOs for the next release.) |
|
I guess your changes might also help to get the failing checks in the dependabot PR #6724 to pass? |
|
Yes, the MacOS checks fail due to what I wrote in the last comment, fixed here. The schema mismatch comes from us having on at least one occasion changed the XML schema on master before/without adapting this in the library as well. |
|
Leaving for you to merge in case there is something that needs to be triggered after. |
The sole purpose of this release is to provide one crucial bit of functionality needed for transitioning to the new author system: reading & writing ORCIDs recorded in the XML.
Longer explanation:
name_variants.yaml, since this gives us the name resolution logic under the old system.python-devalready contains all the updates for the new author system, so we cannot use that branch for the transition either.Making a new release backporting only the ORCID serialization seemed like the cleanest solution to me.