Add database checks to the EEG BIDS import integration test #1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Language: Python
MaximeBICMTL
force-pushed
the
bids_eeg_import_database_integration_tests
branch
2 times, most recently
from
a0f5a82 to
ed98eba
Compare
MaximeBICMTL
added
Area: CI
MaximeBICMTL
changed the title
MaximeBICMTL
force-pushed
the
bids_eeg_import_database_integration_tests
branch
from
f0529f1 to
08a97c2
Compare
MaximeBICMTL
commented
Dec 5, 2025
Comment on lines
+59
to
+60
| 'HardwareFilters': 'n/a', | ||
| 'SoftwareFilters': 'n/a', |
Contributor
Author
There was a problem hiding this comment.
Unrelated to this PR, but shouldn't we store NULL in the database instead of 'n/a' ?
Contributor
There was a problem hiding this comment.
The string 'n/a' is the BIDS-recognized version of NULL and these fields were pulled directly from the *_eeg.json spec
MaximeBICMTL
force-pushed
the
bids_eeg_import_database_integration_tests
branch
from
08a97c2 to
27f034e
Compare
MaximeBICMTL
force-pushed
the
bids_eeg_import_database_integration_tests
branch
5 times, most recently
from
eaefb46 to
d1803e9
Compare
MaximeBICMTL
added
Complexity: Medium
MaximeBICMTL
force-pushed
the
bids_eeg_import_database_integration_tests
branch
from
d1803e9 to
1b26881
Compare
MaximeBICMTL
force-pushed
the
bids_eeg_import_database_integration_tests
branch
from
4645f70 to
e04ba3a
Compare
jeffersoncasimir
approved these changes
Dec 19, 2025
Contributor
jeffersoncasimir
left a comment
jeffersoncasimir
left a comment
There was a problem hiding this comment.
I approve these changes and new helper functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does what the title says it does. The code is rather straightforward. The only somewhat tricky part is that the tests failed because the imported file was already present in Raisinbread. I added some overrides to remove existing physiological files, which is a little dirty IMO but should do the job for now.