Use os.path instead of string operations in EEG
#1342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Language: Python
MaximeBICMTL
added
Category: Refactor
MaximeBICMTL
force-pushed
the
use_path_join_in_eeg
branch
from
9973a4a to
21ece6b
Compare
MaximeBICMTL
changed the title
os.path.join in EEGos.path instead of string operations in EEG
MaximeBICMTL
removed
the
Complexity: Simple
MaximeBICMTL
force-pushed
the
use_path_join_in_eeg
branch
from
21ece6b to
77b1be5
Compare
jeffersoncasimir
approved these changes
Nov 22, 2025
Contributor
jeffersoncasimir
left a comment
jeffersoncasimir
left a comment
There was a problem hiding this comment.
Tested and works as expected!
MaximeBICMTL
added
the
Complexity: Medium
MaximeBICMTL
force-pushed
the
use_path_join_in_eeg
branch
2 times, most recently
from
39b2ffe to
c3588b4
Compare
MaximeBICMTL
force-pushed
the
use_path_join_in_eeg
branch
from
c3588b4 to
901ab28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1325
Description
The BIDS importer refactor changes path manipulation from string concatenation (which is a very fragile way of doing things, notably as it is very sensible to trailing slashes) to
pathlib.Pathoros.pathfunctions and methods. Unfortunately, doing so also requires to update EEG code to this new technique as string-based path manipulation does not work with modern paths (because of the absence of trailing slashes).Details
os.path.joinin EEG code instead of string concatenation.os.path.relpathin EEG code instead of string replacement.