Skip to content

Extract ORM improvements from other PRs (ORM PR 1) #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MaximeBICMTL merged 1 commit into from
Oct 30, 2025
Merged

Extract ORM improvements from other PRs (ORM PR 1) #1303

MaximeBICMTL merged 1 commit into from
Oct 30, 2025

Conversation

@MaximeBICMTL
Copy link
Contributor

@MaximeBICMTL MaximeBICMTL commented Jul 1, 2025 •
edited
Loading

Description

Extract ORM improvements from #1204 and #1211.

Changelog

  • Add the IntDatetime decorator to represent SQL int timestamps as Python datetime objects.
  • Add the TrueFalseBool decorator to represent SQL enum('true', false') values as Python bool objects.
  • Add the DbParameterTypeCategory model.
  • Add the DbParameterTypeCategoryRel model.
  • Add the DbSex model.
  • Add the queries used in the incremental BIDS importer.

@MaximeBICMTL MaximeBICMTL force-pushed the extract_orm_improvements branch from c039bdb to d6939f3 Compare July 1, 2025 07:34
@MaximeBICMTL MaximeBICMTL requested a review from cmadjar July 1, 2025 07:35
@MaximeBICMTL MaximeBICMTL added Area: ORM Issue or PR related to the SQLAlchemy integration Complexity: Simple Issue or PR that should be simple to implement, review, or test labels Jul 1, 2025
@MaximeBICMTL MaximeBICMTL force-pushed the extract_orm_improvements branch from d6939f3 to 1813627 Compare July 1, 2025 07:37
@MaximeBICMTL MaximeBICMTL force-pushed the extract_orm_improvements branch from 1813627 to c4ff59a Compare July 1, 2025 07:38
@MaximeBICMTL MaximeBICMTL added Complexity: Medium Issue or PR that requires a moderate effort or expertise to implement, review, or test and removed Complexity: Simple Issue or PR that should be simple to implement, review, or test labels Jul 1, 2025
@MaximeBICMTL MaximeBICMTL changed the title Extract ORM improvements from other PRs Extract ORM improvements from other PRs (ORM PR 1) Sep 21, 2025
@MaximeBICMTL MaximeBICMTL mentioned this pull request Sep 21, 2025
Merged
jeffersoncasimir
jeffersoncasimir approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MaximeBICMTL MaximeBICMTL changed the base branch from main to maxime_changes October 30, 2025 14:37
@MaximeBICMTL MaximeBICMTL merged commit 3cc34a2 into aces:maxime_changes Oct 30, 2025
9 checks passed
MaximeBICMTL added a commit that referenced this pull request Oct 30, 2025
@MaximeBICMTL
improve orm (#1303)
44d31b0
@cmadjar cmadjar added this to the 28.0.0 milestone Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffersoncasimir jeffersoncasimir jeffersoncasimir approved these changes

@cmadjar cmadjar Awaiting requested review from cmadjar

Assignees

@cmadjar cmadjar

Labels

Area: ORM Issue or PR related to the SQLAlchemy integration Complexity: Medium Issue or PR that requires a moderate effort or expertise to implement, review, or test

Projects

None yet

Milestone

28.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@MaximeBICMTL @jeffersoncasimir @cmadjar