feat: null-safe creator list envelope consistency check - #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
normalizeCreatorListItems()helper increators.serializers.tsthat coercesnull | undefinedprofiles to[]before mapping, so theitemsfield is always an array.serializeCreatorList()signature to acceptCreatorProfile[] | null | undefined.wrapPublicCreatorListResponse()inpublic-creator-list-envelope.utils.tsto coercenull | undefineditems to[]at the envelope level (defence-in-depth).jest.setup.ts+ wiredsetupFilesinjest.config.jsso Jest can load modules that transitively importsrc/config.tswithout requiring real env vars.creator-feed-empty-filters.integration.test.tswith 3 tests assertingitemsis always an array when the data layer returnsnullorundefined.objectContaining({ verified: undefined })incorrectly assumed Zod emits optional absent keys withundefined; corrected to check key absence instead.res.setmock inmakeRes()which causedattachTimestampHeaderto throw, silently swallowing all responses.Why
Creator list endpoints may return
nullinstead of an empty array in edge cases, breaking any client-side iteration that calls.map()or.forEach()onitemswithout a null guard.How to test
Closes #281