feat: null-safe creator list envelope and multi-filter integration tests - #290
Closed
boys-cyberhub wants to merge 1 commit into
Closed
feat: null-safe creator list envelope and multi-filter integration tests#290boys-cyberhub wants to merge 1 commit into
boys-cyberhub wants to merge 1 commit into
Conversation
|
@boys-cyberhub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Splitting into separate PRs per issue as requested by maintainer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add response envelope consistency check for empty list vs null list #281 — Null-safe response envelope for creator list:
normalizeCreatorListItems()helper increators.serializers.tsthat coercesnull | undefinedto[]before mapping.serializeCreatorList()to acceptCreatorProfile[] | null | undefinedand call the normalizer.wrapPublicCreatorListResponse()inpublic-creator-list-envelope.utils.tsto coercenull | undefineditems to[]at the envelope level (defence-in-depth).creator-feed-empty-filters.integration.test.tswith 3 tests asserting thatitemsis always an array when the data layer returnsnullorundefined.Add integration test for creator list filtered by multiple categories simultaneously #282 — Integration tests for multiple category filters with fixture data:
creator-feed-multi-filter.integration.test.tswith a fixture set of 4 creators spanning verified/unverified and two search categories.verified + search,verified + sort + order,verified + search + pagination, full-fixture set, item shape validation, and paginations metadata consistency.fetchCreatorListreceives the correct combination of filter params and that the response envelope serializes non-empty fixture data correctly.Test infrastructure: Added
jest.setup.tswith stub environment variable values and wired it intojest.config.jsviasetupFiles, enabling Jest to run modules that transitively importsrc/config.ts.creator-feed-empty-filters.integration.test.tswhereobjectContaining({ verified: undefined })incorrectly assumed Zod emits optional keys withundefinedvalues (it omits them).Why
Empty-array guarantee prevents client-side
items.forEach/items.mapfrom throwing when an unexpectednullpropagates from the data layer. The multi-filter integration tests exercise the filter combinator path end-to-end with real fixture data rather than empty mocks.How to test
Closes #281
Closes #282