Add helper for formatting large follower counts - #216
Merged
Chucks1093 merged 1 commit intoApr 27, 2026
Conversation
- Extract formatFollowerCount from FollowerCountPill to numberFormat.utils.ts - Apply helper in CreatorCard for creator share supply display - Preserve full value availability via title attribute in FollowerCountPill - Add comprehensive tests for formatFollowerCount function
|
@temitope-007 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the shared helper for formatting large follower counts as requested in issue #191.
Changes Made
Added
formatFollowerCountfunction insrc/utils/numberFormat.utils.ts: A utility function that formats numbers into compact form (e.g., 1.5K, 2M) for display, removing trailing .0 for cleaner output.Updated
FollowerCountPillcomponent: Extracted the formatting logic to use the shared helper and added atitleattribute to preserve full value availability on hover.Applied helper in
CreatorCard: UsedformatFollowerCountfor displaying creator share supply instead of the genericformatCompactNumber, assuming share supply represents follower-like counts.Added comprehensive tests: Included test cases for the new
formatFollowerCountfunction covering various number ranges and edge cases.Validation
Closes #191