Skip to content

Fix #131: Storage optimisation + Fix #136: Cryptographic hardening for RefundVault #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fredericklamar342-prog wants to merge 2 commits into
base: main
Choose a base branch
from
+326 −44
Open

Fix #131: Storage optimisation + Fix #136: Cryptographic hardening for RefundVault #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fabf8d
fix(refund-vault): storage optimisation (#131) and cryptographic hard…
Aug 27, 2026
16109cb
Auto resolve
Ayomikun2005 Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,20 @@ breaking changes bump the **minor** version, and they are called out as such.

### Added

- **Cryptographic hardening for `RefundVault`** (issue #136): a domain
separator (`get_domain_separator`) bound to the contract address at
initialisation, and a monotonic operation nonce (`get_nonce`) incremented
on every successful state-changing call (`deposit`, `refund`, `withdraw`,
`deploy_to_yield`, `withdraw_from_yield`, `harvest_yield`). Events now
carry the nonce so off-chain indexers can detect replays or reorderings.
Separate vault instances produce distinct domain separators, preventing
cross-contract replay of signed authorisations.
- **`RefundVault` storage optimisation** (issue #131): yield-related keys
(`YieldStrategy`, `DeployedPrincipal`, `HarvestedYield`, `ReserveRatio`,
`MaxDeployRatio`) moved from Instance to Persistent storage. Non-yield
calls (`deposit`, `refund`, `withdraw`, `pause`, admin transfer) no
longer load these keys, reducing per-invocation read/write bytes.
Persistent entries receive TTL bumping on every write.
- **Admin events for `RefundVault`** (issue #114): `PauseEvent` and
`UnpauseEvent` carry the ledger sequence so a pause window is reconstructible
from the event log alone, and `RefundWindowUpdatedEvent` carries both the
Expand Down
Loading
Loading