Fix: prune_batches leaves PrunedUpTo pointing past batches it did not actually remove (Auto-Generated) - #211
Merged
Conversation
|
@ndyugwu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
MergeKeeper review unavailable AI provider review response did not contain valid JSON No approval or merge action was taken. |
|
Needs review Linked to The PR removes critical implementation logic from prune_batches and modifies unrelated type signatures like BatchRecord and anchor_batch. Reviewed commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #189
This pull request was generated automatically and scoped strictly to issue #189.
Changes
Fix prune_batches in ReceiptAnchor to avoid incrementing PrunedUpTo past missing or archived batch entries without deleting them. State the PrunedUpTo invariant clearly in doc comments and SECURITY_MODEL.md, emit an observable event/log when a gap is encountered, and ensure restored batches can never end up below PrunedUpTo by halting pruning or handling missing entries safely. Add test coverage for archived gaps and invariants.
Verification
Linked with
Closes #189so the Drips Wave bot resolves the issue on merge.