Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance dynamic range logic #747

Merged
merged 5 commits into from
Jan 12, 2025
Merged

Conversation

afischerdev
Copy link
Collaborator

This is a follow up for PR #729
It fixes the new logic described here

And for the car profiles an activation is possible for track and road in “Dynamic Range Mode”.

@abdullahO2
As before the results are availabe on testserver.

@afischerdev afischerdev added this to the 1.7.8 milestone Dec 14, 2024
@afischerdev
Copy link
Collaborator Author

New logic for the waypoints finding when using dynamic range:
Waypoints that starts or ends in an island exception. Please see example

@afischerdev
Copy link
Collaborator Author

@abdullahO2
The new library is now available on the test server.

@abdullahO2
Copy link

abdullahO2 commented Dec 24, 2024

@afischerdev

Thank you for the update! I've been testing the new library on the test server, and the results are truly impressive. The new dynamic range logic is working remarkably well.

However, I've noticed significant slowdowns in some cases, eventually leading to a complete loss of server response. I encountered a "java.lang.OutOfMemoryError: Java heap space" error similar to the one reported previously (see link below).

Here are a couple of examples where I experienced the slowdowns before the server stopped responding:

#729 (comment)

I suspect that the slowdowns and the OutOfMemoryError might be related to enabling the highway=track mapping along with the dynamic range, as I noticed similar behavior before the latest changes. Could you please investigate this further? In the meantime, I'll continue testing when the server is back online.

@afischerdev
Copy link
Collaborator Author

@abdullahO2
I've started the test server again.

Hard to say what happens. I have no idea.
I made a local stress test with the test server start parameter and your two requests and a hundred runs from different threads - no abnormalities.

@abdullahO2
Copy link

@afischerdev

Thank you for restarting the test server!

I've been testing the latest version extensively, and I haven't encountered any other significant issues. The dynamic range feature is working exceptionally well, and I'm very happy with the results.

Thank you again for all your hard work and dedication to this feature. It's truly made a huge difference!

@afischerdev
Copy link
Collaborator Author

@abdullahO2
Thanks for all your help and the nice examples.

@afischerdev afischerdev merged commit e521eac into abrensch:master Jan 12, 2025
2 checks passed
@abdullahO2
Copy link

@afischerdev

You're very welcome! It's been a pleasure working with you on this. This feature was a dream of mine to have in BRouter, and I'm incredibly grateful for your help in making it a reality. Thank you for your patience, dedication, and expertise throughout this process. It's truly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants