-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance dynamic range logic #747
Conversation
New logic for the waypoints finding when using dynamic range: |
@abdullahO2 |
Thank you for the update! I've been testing the new library on the test server, and the results are truly impressive. The new dynamic range logic is working remarkably well. However, I've noticed significant slowdowns in some cases, eventually leading to a complete loss of server response. I encountered a "java.lang.OutOfMemoryError: Java heap space" error similar to the one reported previously (see link below). Here are a couple of examples where I experienced the slowdowns before the server stopped responding:
I suspect that the slowdowns and the OutOfMemoryError might be related to enabling the highway=track mapping along with the dynamic range, as I noticed similar behavior before the latest changes. Could you please investigate this further? In the meantime, I'll continue testing when the server is back online. |
@abdullahO2 Hard to say what happens. I have no idea. |
Thank you for restarting the test server! I've been testing the latest version extensively, and I haven't encountered any other significant issues. The dynamic range feature is working exceptionally well, and I'm very happy with the results. Thank you again for all your hard work and dedication to this feature. It's truly made a huge difference! |
@abdullahO2 |
You're very welcome! It's been a pleasure working with you on this. This feature was a dream of mine to have in BRouter, and I'm incredibly grateful for your help in making it a reality. Thank you for your patience, dedication, and expertise throughout this process. It's truly appreciated. |
This is a follow up for PR #729
It fixes the new logic described here
And for the car profiles an activation is possible for
track
androad
in “Dynamic Range Mode”.@abdullahO2
As before the results are availabe on testserver.