-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing switch cases and update compiler check #457
base: master
Are you sure you want to change the base?
fix: add missing switch cases and update compiler check #457
Conversation
packages/sign_in_with_apple/sign_in_with_apple/darwin/Classes/SignInWithAppleError.swift
Show resolved
Hide resolved
@juliansteenbakker Thanks, I'll look into this and see what we can do. Could you please rebase this onto |
089071f
to
41c3155
Compare
packages/sign_in_with_apple/sign_in_with_apple/darwin/Classes/SignInWithAppleError.swift
Outdated
Show resolved
Hide resolved
I have applied your improvements @tp. I hope we can get this merged soon 😄 |
Thanks @juliansteenbakker. I'll take another look :) |
Fixes warning during build about switch case not being exhaustive