Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing switch cases and update compiler check #457

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

juliansteenbakker
Copy link
Contributor

Fixes warning during build about switch case not being exhaustive

@tp
Copy link
Collaborator

tp commented Jan 21, 2025

@juliansteenbakker Thanks, I'll look into this and see what we can do.

Could you please rebase this onto master so we get a working CI (sorry, that was just merged from our end). Then we can also ensure that all supported/checked Xcode versions are properly working.

@juliansteenbakker juliansteenbakker force-pushed the fix/switch-case-exhaustive branch from 089071f to 41c3155 Compare January 21, 2025 14:51
@juliansteenbakker
Copy link
Contributor Author

I have applied your improvements @tp. I hope we can get this merged soon 😄

@tp
Copy link
Collaborator

tp commented Feb 26, 2025

I have applied your improvements @tp. I hope we can get this merged soon 😄

Thanks @juliansteenbakker. I'll take another look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants