Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match binaries to source using elf symbols #1621

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Match binaries to source using elf symbols #1621

wants to merge 3 commits into from

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Mar 11, 2025 •
edited
Loading

Reference: #1403
Reference: aboutcode-org/elf-inspector#9

@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Mar 11, 2025
Open
pombredanne
pombredanne approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine. Thanks! 🌞

@tdruez
Copy link
Contributor

tdruez commented Mar 11, 2025

@AyanSinhaMahapatra The code looks fine but I would prefer we release a proper version of elf-inspector instead of using a git commit.

@AyanSinhaMahapatra
Use elf-inspector v0.0.3
b7fbf9a 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Copy link
Member Author

@tdruez added as a dependency the latest release of elf-inspector, ready for your review.

@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Mar 17, 2025
Open
8 tasks
@tdruez
Copy link
Contributor

tdruez commented Mar 17, 2025

@AyanSinhaMahapatra Before merging, could you confirm that the following pipe functions are properly covered by unit tests?

  • d2d.map_elfs_with_dwarf_paths(project=self.project, logger=self.log)
  • d2d.map_elfs_binaries_with_symbols(project=self.project, logger=self.log)
  • d2d.map_rust_binaries_with_symbols(project=self.project, logger=self.log)

Also, do we have a unit test that validates the whole pipeline execution with a focus on the ELF inspection?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

@tdruez tdruez Awaiting requested review from tdruez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AyanSinhaMahapatra @tdruez @pombredanne