Add support to mine cargo Package-URLs #679
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziadhany
force-pushed
the
min-cargo
branch
2 times, most recently
from
5cdc47b to
ae60ff2
Compare
AyanSinhaMahapatra
requested changes
Sep 10, 2025
There was a problem hiding this comment.
Thanks @ziadhany, looks good as a start. Please see my comments for your consideration
This was referenced Sep 17, 2025
|
@ziadhany what's left todo here? |
|
@pombredanne I just need to use the common function. But I already tested running the workflow in this repo: https://github.com/ziadhany/cargo-test/. I will update it today. |
JonoYang
requested changes
Sep 19, 2025
JonoYang
requested changes
Sep 19, 2025
AyanSinhaMahapatra
requested changes
Sep 23, 2025
There was a problem hiding this comment.
Thanks @ziadhany, looking good.
See my comments for your consideration. We can also start testing this in the aboutcode-data CI now
Signed-off-by: ziad hany <[email protected]>
Signed-off-by: ziad hany <[email protected]>
Refactor code to be compatible with the new pipeline. Signed-off-by: ziad hany <[email protected]>
Add logging and fix bug in process_cargo_packages Signed-off-by: ziad hany <[email protected]>
Signed-off-by: ziad hany <[email protected]>
Signed-off-by: ziad hany <[email protected]>
Fix bug in process_cargo_packages. Signed-off-by: ziad hany <[email protected]>
Signed-off-by: ziad hany <[email protected]>
Signed-off-by: ziad hany <[email protected]>
Signed-off-by: ziad hany <[email protected]>
Signed-off-by: ziad hany <[email protected]>
Signed-off-by: ziad hany <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.