502 queue priority update #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
keshav-space
requested changes
Jul 18, 2024
There was a problem hiding this comment.
Thanks, @JonoYang.
Looking good! It seems like you forgot to pass the priority in priority_queue.py command. https://github.com/nexB/purldb/blob/275d6daa47276c32dd50f0f8f622d2472bae6796/minecode/management/commands/priority_queue.py#L117-L120
Also, it would be nice to have a test to ensure that these priority values are indeed making their way to process_request in visitors.
AyanSinhaMahapatra
approved these changes
Jul 18, 2024
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
|
Thanks for the review! @keshav-space I've created a test that checks the priority of the created ScannableURIs from a request to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
/api/collectand/api/collect/index_packages/endpoints where purls with versions are placed in the front of the scan queue. This is done as it is assumed that if the user knows which versions of a package they want to look at, they would probably want to see it sooner.