Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #26

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Fix tests #26

merged 2 commits into from
Jun 26, 2024

Conversation

rodrigoborgesdeoliveira
Copy link
Contributor

  • Downgraded got to v11. v12 is pure ESM and breaks mocha (or at least the current mocha integration).
  • Fix Fix tests #18.
    • Tests were missing a mocking implementation for the verify access token method. The mocks have also been refactored as the previous mocking approach would make the this context result in an empty context and would break the done method, which calls this.success/this.fail.

@rodrigoborgesdeoliveira
Downgrade got back to v11
a29ff4f 
v12 is now pure ESM and breaks mocha.
@rodrigoborgesdeoliveira
Fix tests failing due to mocked strategies
632a46e 
The "this" context would become innacessible with the previous mocking
approach.
@rodrigoborgesdeoliveira rodrigoborgesdeoliveira changed the title Fix/tests Fix tests Jun 24, 2024
@rodrigoborgesdeoliveira rodrigoborgesdeoliveira mentioned this pull request Jun 24, 2024
Merged
@abouroubi abouroubi merged commit da433a0 into abouroubi:master Jun 26, 2024
1 check passed
@rodrigoborgesdeoliveira rodrigoborgesdeoliveira deleted the fix/tests branch June 26, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abouroubi abouroubi abouroubi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix tests
2 participants
@rodrigoborgesdeoliveira @abouroubi