fix(cli): route spawn failures and hangs into the err convention - #26
Merged
Conversation
vim.system throws on a missing or non-executable cmd instead of returning a code, so a user without but (or with cmd misconfigured) got an E5108 stacktrace from every :Butler* command rather than the designed callback -> vim.notify path. pcall the probe and both spawn sites and surface cli.unusable (missing binary, probe timeout) or the existing version message. Cap every blocking wait(): probe 5s, run_sync 30s (SIGKILL + code 124 reported as a timeout error), raw git calls in commit_diff/timeline 10s — a hung subprocess must not freeze the editor. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing/misconfigured
butthrew E5108 stacktraces from every :Butler* command (vim.system throws on ENOENT, bypassing the callback err convention). Now pcall-wrapped with a friendly cli.unusable message; all blocking wait() calls get timeouts (probe 5s, run_sync 30s, raw git 10s) so a hung subprocess cannot freeze the editor.Found via a strap native-DAP discovery session against a live nvim. Includes .strap harness wiring.
🤖 Generated with Claude Code