Open
Conversation
- Implement Soroban contract address format validation (56-char base32, 'C' prefix) - Add network connectivity checks with configurable timeouts (default 5s) - Distinguish between validation errors, transient errors, and configuration errors - Provide actionable error messages for deployment troubleshooting - Comprehensive unit and integration tests with property-based testing - Support async endpoint validation for pre-deployment verification Resolves issue StellerCraft#52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Validate contract addresses and verify configured Horizon endpoints are reachable before deployment.
Changes
Implementation
Files Created
Files Modified
Error Types
Test Coverage
✅ 938 lines of tests (unit, integration, property-based)
✅ Contract validation (format, length, prefix, charset)
✅ Endpoint checks (Horizon, Soroban RPC, combined)
✅ Mock HTTP responses (various status codes)
✅ Timeout and error scenarios
✅ Edge cases and error differentiation
Usage
Resolves StellerCraft#52