-
Notifications
You must be signed in to change notification settings - Fork 61
Release 2.10.1 #2062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.10.1 #2062
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis update increments the package version from 2.10.0 to 2.10.1, documents the new patch release in the changelog, and updates the exported Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/platform/react-hooks/src/AblyReactHooks.ts (1)
15-15: Centralize version source to avoid manual drift
versionis now hard-coded here and inpackage.json. Two separate declarations are easy to get out-of-sync on the next bump.
Consider injecting the package version at build time (e.g. viarollup-plugin-replace,webpack DefinePlugin, or simply reading frompackage.jsonin a small build-step) so there’s a single source of truth.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)package.json(1 hunks)src/platform/react-hooks/src/AblyReactHooks.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: test-npm-package
- GitHub Check: test-node (16.x)
- GitHub Check: test-node (18.x)
- GitHub Check: test-node (20.x)
- GitHub Check: test-browser (chromium)
- GitHub Check: test-browser (firefox)
- GitHub Check: test-browser (webkit)
🔇 Additional comments (2)
package.json (1)
4-4: Remember to commit the lock-file
package.json’s version is updated, but the PR does not show a matching change topackage-lock.json/npm-shrinkwrap.json.
If the repository tracks a lock-file, bump its"version"field as well to keepnpm publishwarnings away.CHANGELOG.md (1)
5-8: Changelog entry looks goodEntry follows existing style and links resolve correctly.
Summary by CodeRabbit
Bug Fixes
Chores