Add IPv6 City lookup function and expose netmask fields #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we could retrieve this information for successful lookups with the prior changes, we could not do so if the lookups failed. Being able to know this when the lookup failed is useful for knowing how large the gap in the database is so that we can skip over it to the next.
|
Ah, I see #29 also adds a way to do IPv6 lookups, though in a bit different way. |
This is useful for iterating the database as we will receive the netmask of the gap.
Support getting the country name from the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits do a few things. I'd be happy to split them into separate PRs if you prefer.
Primarily:
netmaskfield ofGeoIPRecordnetmaskfield ofGeoIP. This is useful if we don't find a record and so can't use the netmask fromGeoIPRecordThank you!