Add method to get database infos #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abh
requested changes
Jul 19, 2017
geoip.go
Outdated
|
|
||
| cdbinfo := C.GeoIP_database_info(gi.db) | ||
| if cdbinfo != nil { | ||
| databaseInfos = C.GoString(cdbinfo) |
There was a problem hiding this comment.
doesn't this also need
defer C.free(unsafe.Pointer(cdbinfo))
?
There was a problem hiding this comment.
That's an unexpected destroy in my copy/paste... Fixing...
geoip.go
Outdated
| return | ||
| } | ||
|
|
||
| func (gi *GeoIP) GetDatabaseInfo() (databaseInfos string) { |
There was a problem hiding this comment.
I was going to complain about the named return variable, but it looks like I was doing that elsewhere here too. :-)
There was a problem hiding this comment.
I just copied/pasted one of your methods, but I prefer the unnamed return version
|
OK for the tests, but the test-db files don't provided these database informations. So checking with empty string would not be an appropriate test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.