Skip to content

lint: javascript#69

Merged
mattrandallbecker merged 11 commits intomainfrom
dcreey/js-ts
May 14, 2025
Merged

lint: javascript#69
mattrandallbecker merged 11 commits intomainfrom
dcreey/js-ts

Conversation

@dcreey
Copy link
Copy Markdown
Contributor

@dcreey dcreey commented May 12, 2025

Add a new action for linting javascript/typescript/node based code.

  • Runs on every package.json in the repo. Shards to one vm per package.json
  • Runs npm run lint if a lint command is defined in the package.json
  • Otherwise runs npx eslint . if an eslint config is present.
  • Otherwise does nothing and instead prints a notice to add a "lint" command to your package.json or add an eslint config.
  • NOTE: I considered using gts - but it just adds a lint command to your package.json and is not CI friendly as it generates a lot of source code if you haven't used it before in a repo.
  • TODO: lint standalone js

Tested on github-token-minter by manually adding: abcxyz/github-token-minter#207

@sethvargo
Copy link
Copy Markdown
Contributor

Got em!

CleanShot 2025-05-12 at 15 23 23@2x

@abcxyz abcxyz deleted a comment from github-actions Bot May 13, 2025
@dcreey
Copy link
Copy Markdown
Contributor Author

dcreey commented May 13, 2025

Got em!

CleanShot 2025-05-12 at 15 23 23@2x

Alas. A victim of my own design

@dcreey dcreey marked this pull request as ready for review May 13, 2025 21:26
@dcreey dcreey requested a review from a team as a code owner May 13, 2025 21:26
@mattrandallbecker mattrandallbecker merged commit 3b3a945 into main May 14, 2025
2 checks passed
@mattrandallbecker mattrandallbecker deleted the dcreey/js-ts branch May 14, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants