Skip to content

rockPaperScissors project #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abbygottlich wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

rockPaperScissors project #3

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a2eeec
rockPaperScissors project
abbygottlich Oct 14, 2018
4dfcb64
shortened my conditionals
abbygottlich Nov 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions 01week/rockPaperScissors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,44 @@ const rl = readline.createInterface({
output: process.stdout
});

// user1 makes move
// user2 makes move
// user1 chooses rock, user2 chooses paper - user2 wins
// user1 chooses rock, user2 chooses scissors - user1 wins
// user1 chooses rock, user2 chooses rock - it's a tie
// user1 chooses paper, user2 chooses rock - user1 wins
// user1 chooses paper, user2 chooses scissors - user2 wins
// user1 chooses paper, user2 chooses paper - it's a tie
// user1 chooses scissors, user2 chooses rock - user2 wins
// user1 chooses scissors, user2 chooses paper - user1 wins
// user1 chooses scissors, user2 chooses scissors - it's a tie

function rockPaperScissors(hand1, hand2) {

// Write code here

if(hand1=='rock' && hand2 =='paper'){
Copy link

@reneemeyer reneemeyer Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job, but how could you simplify?

return 'Player 2 Wins!'
}else if(hand1=='rock' && hand2 =='scissors'){
return 'Player 1 Wins!'
}else if(hand1=='paper' && hand2 =='rock'){
return 'Player 1 Wins!'
}else if(hand1=='paper' && hand2 =='scissors'){
return 'Player 2 Wins!'
}else if(hand1=='scissors' && hand2 =='rock'){
return 'Player 2 Wins!'
}else if(hand1=='scissors' && hand2 =='paper'){
return 'Player 1 Wins!'
}else if(hand1=='rock' && hand2=='rock'){
return 'It is a tie!'
}else if(hand1=='paper' && hand2=='paper'){
return 'It is a tie!'
}else if(hand1=='scissors' && hand2=='scissors'){
return 'It is a tie!'
}else {
return 'Please enter "rock", "paper", or "scissors"'
}

}

function getPrompt() {
Expand Down