Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] savefile, dispatcher rewrite, player login #1

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

abadger
Copy link
Owner

@abadger abadger commented Mar 26, 2019

Implementing savefiles and several refactors that go along with it.

@abadger abadger force-pushed the feature/savefile branch 2 times, most recently from 4fd108c to 6199801 Compare March 30, 2019 14:28
@coveralls
Copy link

Coverage Status

Coverage increased (+9.1%) to 58.931% when pulling 6199801 on feature/savefile into 0e90ea9 on master.

@coveralls
Copy link

coveralls commented Mar 30, 2019

Coverage Status

Coverage increased (+9.2%) to 58.884% when pulling 72c72d8 on feature/savefile into f6cfc18 on master.

@codecov-io
Copy link

codecov-io commented Mar 30, 2019

Codecov Report

Merging #1 into master will increase coverage by 9.11%.
The diff coverage is 57.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   49.04%   58.15%   +9.11%     
==========================================
  Files          14       15       +1     
  Lines         942      889      -53     
  Branches      114      106       -8     
==========================================
+ Hits          462      517      +55     
+ Misses        474      366     -108     
  Partials        6        6
Impacted Files Coverage Δ
magnate/dispatcher.py 0% <0%> (ø) ⬆️
magnate/magnate.py 0% <0%> (ø) ⬆️
magnate/auth.py 100% <100%> (ø)
magnate/errors.py 100% <100%> (ø) ⬆️
magnate/config.py 100% <100%> (ø) ⬆️
magnate/savegame/db.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6cfc18...72c72d8. Read the comment docs.

abadger added 5 commits April 2, 2019 20:42
* Switch savegame/db.py to use new logging conventions
* Update logging calls in config.py
* Add logging to urwid auth screen
All of the events which the ui emits for the backend to handle will have
their callbacks here.  These are intended to be light wrappers to code
deeper into the backend to handle
* Add passlib config to config file
* Also enhance logging in config.py
* Username and password to log in.  Password hashes saved in a dbm file.
* Check passwords with libpwquality
* passlib
* pwquality bindings for python3
* cracklib-runtime for password dictionaries
* alphabetize the requirements list
@abadger abadger force-pushed the feature/savefile branch from e689853 to 80ecf8e Compare April 3, 2019 03:43
* Game select screen for selecting a savegame
* New account dialog for creating a new user account
* Add debug logging to there widgets
Base automatically changed from master to main January 22, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants