You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As mentioned in #30, the repo could do with some automated building.
I have add this support to the .travis.yml file. I have also added the us of build stages, which makes use of concurrent execution of jobs, which may help improve the speed of CI checks.
the Deploy stage executes only for python 3.6, and creates a bdist_wheel, which I believe to be universally installable. Correct me if I'm wrong here, I'm not well read on the differences of the distributions.
In order to avoid building and pushing to pypi on every push, the conditional tags: true was added - that way, it is only built if you push a tagged commit.
The password for pypi should be encrypted using the travis CLI - since I'm guessing you won't want to share your pypi password with the world ;) see here for more information about this: https://docs.travis-ci.com/user/deployment/pypi/
Hi @nlsdfnbch
Extremely sorry for my super late review. Since, its christmas time(peak season), didn't get time for my personal project.
I am new to travis ci build features and needed some time to read about it also and here are my following reviews:
Can you create another parallel job to lint & deploy for Python2(2.7) also?
So, people can download version either for 2.7 or 3.6. (Let me know if any PyPi exclusive config change is required external to travis.yml)
(This can be addressed later. More sort of asking for opinion on organizing and improving tests and reducing build time) Should we use different test suite for python2(2.7) and python3(3.6)?{Will improve build time by running parallely} And then use build matrix 'matrix:'? Though I am confused when to use Jobs and matrix. Already an open issue to travis-ci regarding it (jobs vs. matrix: What's the difference? travis-ci/docs-travis-ci-com#1500)
Eg:
The reason will be displayed to describe this comment to others. Learn more.
Since, 3.6 will the released pypi package, we can remove 3.3 and add 3.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #30, the repo could do with some automated building.
I have add this support to the
.travis.ymlfile. I have also added the us ofbuild stages, which makes use of concurrent execution of jobs, which may help improve the speed of CI checks.the
Deploystage executes only for python 3.6, and creates abdist_wheel, which I believe to be universally installable. Correct me if I'm wrong here, I'm not well read on the differences of the distributions.In order to avoid building and pushing to
pypion every push, the conditionaltags: truewas added - that way, it is only built if you push a tagged commit.The password for pypi should be encrypted using the
travis CLI- since I'm guessing you won't want to share your pypi password with the world ;) see here for more information about this:https://docs.travis-ci.com/user/deployment/pypi/
Let me know what you think!