Allow marking ClientStream as terminated #272
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quietvoid
force-pushed
the
stream_terminated
branch
from
aef6577 to
6b3f681
Compare
quietvoid
force-pushed
the
stream_terminated
branch
from
6b3f681 to
a730542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the right way to go about things but it's how my current code is designed and it has been working fine for me.
That way streams can be individually set terminated manually to avoid panics when using
select_next_some().Along with
select!andfutures::future::select_allExample scenario:
PingTimeoutQUITThere might be a better way to react to timeouts but having the ability to set terminated should still be useful.