Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf157bb111
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name: Goose-darwin-arm64 | ||
| path: ui/desktop/out/Goose-darwin-arm64/Goose.zip | ||
| name: Goose-darwin-arm64-unsigned | ||
| path: ui/desktop/out/Goose-darwin-arm64/ |
There was a problem hiding this comment.
Prevent unsigned arm64 zip from colliding with release artifact
Uploading the entire Goose-darwin-arm64/ directory here also includes the unsigned Goose.zip, but sign-desktop later uploads a signed Goose.zip under a different artifact name. In signing-enabled runs, downstream workflows (for example release.yml with download-artifact + merge-multiple: true) merge artifact contents into one directory, so the duplicate Goose.zip names can overwrite/race and cause the unsigned binary to be released instead of the signed one. Keep the intermediate artifact to Goose.app (or otherwise avoid publishing a same-named zip before signing).
Useful? React with 👍 / 👎.
| name: Goose-darwin-x64 | ||
| path: ui/desktop/out/Goose-darwin-x64/Goose_intel_mac.zip | ||
| name: Goose-darwin-x64-unsigned | ||
| path: ui/desktop/out/Goose-darwin-x64/ |
There was a problem hiding this comment.
Prevent unsigned Intel zip from colliding with release artifact
This intermediate upload now includes Goose_intel_mac.zip (unsigned) because it archives the whole output directory, while sign-desktop-intel later uploads a signed Goose_intel_mac.zip. When release jobs merge all artifacts into one directory (download-artifact with merge-multiple: true), those same-named files conflict, so the final published Intel zip can be the unsigned one depending on extraction order. Exclude/rename the unsigned zip in the build artifact so only the signed zip is eligible for publication.
Useful? React with 👍 / 👎.
Code signing can fail for all sorts of reasons. This lets us retry without rebuilding.